Skip to content

[TOOL-3259] Dashboard: Fix Claimable Module UI crashing on for ERC20 token currency set in claim condition #6114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2025
Merged

[TOOL-3259] Dashboard: Fix Claimable Module UI crashing on for ERC20 token currency set in claim condition #6114

merged 1 commit into from
Jan 30, 2025

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Jan 30, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on enhancing the Claimable component by implementing a query for fetching currency decimals and improving the handling of currency-related logic.

Detailed summary

  • Added useQuery for fetching currency decimals instead of using useReadContract.
  • Updated logic to determine when to fetch currency decimals.
  • Refactored currency contract retrieval to be more dynamic.
  • Changed the condition for loading state based on currency decimals.
  • Disabled the "Add Claim Condition" button if the user is not the owner.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Jan 30, 2025

TOOL-3259 Failed to render ClaimableERC721 module for ERC721 Base

@changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 541cf0b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 30, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 3:29pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 3:29pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 3:29pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 3:29pm

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground January 30, 2025 10:17 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui January 30, 2025 10:17 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 30, 2025 10:17 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jan 30, 2025
@MananTank MananTank marked this pull request as ready for review January 30, 2025 10:18
@MananTank MananTank requested review from a team as code owners January 30, 2025 10:18
@MananTank Graphite App
Copy link
Member Author

MananTank commented Jan 30, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Jan 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.87%. Comparing base (c650221) to head (541cf0b).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6114   +/-   ##
=======================================
  Coverage   56.87%   56.87%           
=======================================
  Files        1153     1153           
  Lines       63896    63896           
  Branches     5180     5180           
=======================================
  Hits        36344    36344           
  Misses      26825    26825           
  Partials      727      727
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from c650221
packages 55.07% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 30, 2025 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.6 KB (0%) 933 ms (0%) 1.1 s (+78.34% 🔺) 2 s
thirdweb (cjs) 122.39 KB (0%) 2.5 s (0%) 1.6 s (+3.73% 🔺) 4 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 325 ms (+106.77% 🔺) 436 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 13 ms (-6.99% 🔽) 23 ms
thirdweb/react (minimal + tree-shaking) 19.28 KB (0%) 386 ms (0%) 262 ms (+35.19% 🔺) 647 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 30, 2025 •
edited
Loading

Merge activity

@MananTank
[TOOL-3259] Dashboard: Fix Claimable Module UI crashing on for ERC20 …
541cf0b 
…token currency set in claim condition (#6114)

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on enhancing the `ClaimableModule` component by integrating the `useQuery` hook for fetching currency decimals and refining the logic for determining when to fetch this data.

### Detailed summary
- Added `useQuery` to fetch currency decimals based on the `claimConditionCurrency`.
- Refactored the logic to check if currency decimals should be fetched.
- Updated the conditional rendering of fetched data in the `ClaimableModule`.
- Made the "Add Claim Condition" button disabled based on `props.isOwnerAccount`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@graphite-app graphite-app bot merged commit 541cf0b into main Jan 30, 2025
31 checks passed
@graphite-app graphite-app bot deleted the TOOL-3259 branch January 30, 2025 15:30
@vercel vercel bot temporarily deployed to Production – docs-v2 January 30, 2025 15:30 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground January 30, 2025 15:30 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui January 30, 2025 15:30 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaryash90 kumaryash90 kumaryash90 approved these changes

Assignees

@MananTank MananTank

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MananTank @kumaryash90